Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Theming and add basic Component lib #37

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Implement Theming and add basic Component lib #37

wants to merge 19 commits into from

Conversation

Comeza
Copy link
Member

@Comeza Comeza commented Jun 2, 2024

Closes #30, #32

Theming

  • Load themes dynamically
  • Integrate with tailwind
  • Create default theme

Component lib (lila)

  • Buttons
  • Text input
  • (Color picker)

@Comeza Comeza added the frontend About the Frontend (liberica) label Jun 2, 2024
@Comeza Comeza added this to the O-Phase 24 milestone Jun 2, 2024
@Comeza Comeza self-assigned this Jun 2, 2024
liberica/src/page/CreateTeam.tsx Outdated Show resolved Hide resolved
liberica/src/lib/theme.ts Outdated Show resolved Hide resolved
liberica/src/lib/util.ts Outdated Show resolved Hide resolved
liberica/src/lib/colors.ts Outdated Show resolved Hide resolved
liberica/src/lib/colors.ts Outdated Show resolved Hide resolved
@Comeza Comeza force-pushed the themes branch 2 times, most recently from 11f6a67 to 9f68490 Compare June 13, 2024 22:33
Comment on lines -22 to -30
export function HomeButton() {
const navigate = useNavigate();

return (
<Button onClick={() => navigate("/")}>
<FaHome />
</Button>
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the home button?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently experimenting with the Navbar and couldn't find space for it (It also didn't fit the theme). I will put it back sometime later.

Comment on lines -35 to -48
function ResetMapViewButton() {
const map = useMap();
const { t } = useTranslation();

return (
<div className="leaflet-top leaflet-center">
<div className="leaflet-control leaflet-bar">
<Button onClick={() => map.setView(CENTER, DEFAULT_ZOOM)}>
{t("ResetMapView")}
</Button>
</div>
</div>
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I find it pretty useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend About the Frontend (liberica)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tailwind code to be more consistent Use tailwind themes for more consistent styling
2 participants